linux-kernel - Re: time.c:undefined reference to `mach_get_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 May 2022 09:21:32 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Daniel Palmer <daniel@...f.com>
Subject: Re: time.c:undefined reference to `mach_get_rtc_pll'

On Wed, May 4, 2022 at 3:33 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Wed, May 4, 2022 at 2:25 PM Arnd Bergmann <arnd@...db.de> wrote:
> > On Wed, May 4, 2022 at 11:14 AM kernel test robot <lkp@...el.com> wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   107c948d1d3e61d10aee9d0f7c3d81bbee9842af
> > > commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@...el.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
> > > >> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
> > >    m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
> > >    m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
> > >
> >
> > I think this is just another build failure that was hidden before my patch,
> > not caused by my patch.
>
> That's an m68knommu kernel build with CONFIG_RTC_DRV_GENERIC=y,
> I guess?

Correct, the  .config file is linked in the original report, just double-checked
that. More importantly, it's a nommu M68KCLASSIC (dragonball) config,
so the existing #ifdef CONFIG_M68KCLASSIC check in
arch/m68k/kernel/time.c is insufficient.

       Arnd