linux-kernel - Re: [PATCH] i2c: s3c2410: fix returnvar.cocci warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60612719-a41d-3523-0109-2f2406d31d6e@linaro.org>
Date:   Fri, 6 May 2022 09:52:31 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yihao Han <hanyihao@...o.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kernel@...o.com
Subject: Re: [PATCH] i2c: s3c2410: fix returnvar.cocci warning

On 06/05/2022 09:31, Yihao Han wrote:
> Fix the following coccicheck warning:
> 
> drivers/i2c/busses/i2c-s3c2410.c:388:5-8: Unneeded variable: "ret".
> Return "0" on line 551
> 
> Signed-off-by: Yihao Han <hanyihao@...o.com>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

This was already reported:
https://lore.kernel.org/all/0d1a0027-e74d-9f07-3b96-372b5ca14ae3@canonical.com/

Please apply instead my previous suggestion.


Best regards,
Krzysztof