linux-kernel - Re: [PATCH 2/4] mm/memofy-failure.c:: simplify num_poisoned_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220506085559.GB1356094@u2004>
Date:   Fri, 6 May 2022 17:55:59 +0900
From:   Naoya Horiguchi <naoya.horiguchi@...ux.dev>
To:     zhenwei pi <pizhenwei@...edance.com>
Cc:     akpm@...ux-foundation.org, naoya.horiguchi@....com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [PATCH 2/4] mm/memofy-failure.c:: simplify num_poisoned_pages_dec

On Fri, Apr 29, 2022 at 10:22:04PM +0800, zhenwei pi wrote:
> Don't descrease the number of poisoned pages in page_alloc.c, let the
        ^^^^
        decrease?

> memory-failure.c do inc/dec poisoned pages only.
> 
> Also simplify unpoison_memory(), only descrease the number of
                                        ^^^^
                                        same typo

> poisoned pages when:
>  - TestClearPageHWPoison() succeed
>  - put_page_back_buddy succeed
> 
> After descreasing, print necessary log.
        ^^^^
        ditto

> 
> Finally, remove clear_page_hwpoison() and unpoison_taken_off_page().
> 
> Cc: Wu Fengguang <fengguang.wu@...el.com>
> Signed-off-by: zhenwei pi <pizhenwei@...edance.com>

Otherwise, the changes look good to me.

Acked-by: Naoya Horiguchi <naoya.horiguchi@....com>