linux-kernel - Re: [RESEND PATCH v3] scsi: ufs: exclude UECxx from SFR dump list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon,  2 May 2022 20:51:39 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     vkumar.1997@...sung.com, linux-kernel@...r.kernel.org,
        jejb@...ux.ibm.com, sc.suh@...sung.com, hy50.seo@...sung.com,
        beanhuo@...ron.com, cang@...eaurora.org, bhoon95.kim@...sung.com,
        sh425.lee@...sung.com, avri.altman@....com,
        alim.akhtar@...sung.com, adrian.hunter@...el.com,
        Kiwoong Kim <kwmad.kim@...sung.com>, linux-scsi@...r.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [RESEND PATCH v3] scsi: ufs: exclude UECxx from SFR dump list

On Thu, 31 Mar 2022 10:24:05 +0900, Kiwoong Kim wrote:

> v2 -> v3: add fixes
> v1 -> v2: does skipping only for zero offset
> 
> These are ROC type things that means their values
> are cleared when the SFRs are read.
> They are usually read in ISR when an UIC error occur.
> Thus, their values would be zero at many cases. And
> there might be a little bit risky when they are read to
> be cleared before the ISR reads them, e.g. the case that
> a command is timed-out, ufshcd_dump_regs is called in
> ufshcd_abort and an UIC error occurs at the nearly
> same time. In this case, ISR will be called but UFS error handler
> will not be scheduled.
> This patch is to make UFS driver not read those SFRs in the
> dump function, i.e. ufshcd_dump_regs.
> 
> [...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: ufs: exclude UECxx from SFR dump list
      https://git.kernel.org/mkp/scsi/c/ef60031022eb

-- 
Martin K. Petersen	Oracle Linux Engineering