linux-kernel - Re: [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220506112209.hslb67cuinntusuc@ppc.localdomain>
Date:   Fri, 6 May 2022 19:22:09 +0800
From:   Wang Cheng <wanngchenng@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     paskripkin@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb_read8()
 and friends

On 22/05/06 10:10AM, Dan Carpenter wrote:
> Setting "data = 0" will silence the KMSAN warnings but it doesn't fix
> the bug which is that r8712_usbctrl_vendorreq() treats partial reads
> as success.
> 
> The usb_control_msg() returns negatives on total failure and it returns
> small positives on partial failure.  So take the code that I gave you
> before and put that into r8712_usbctrl_vendorreq().  That's patch 1.
> These patches become 2 and 3.

Ah, you mentioned in previous review "But then another problem is that
"status" can be less than "len"." I missed it then.

- w

> 
>         status = usb_control_msg();
>         if (status < 0)
>                 goto free;
>         if (status != len) {
>                 status = -EREMOTEIO;
>                 goto free;
>         }
>         if (requesttype == 0x01)
>                 memcpy(pdata, pIo_buf, status);
> 
> regards,
> dan carpenter
>