linux-kernel - Re: [PATCH -next] drm/msm: Add missing OF dependency for DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbe452b1-7f6a-141c-5fe3-bd889c62abc7@linaro.org>
Date:   Fri, 6 May 2022 14:36:43 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>, robdclark@...il.com,
        sean@...rly.run, quic_abhinavk@...cinc.com, airlied@...ux.ie,
        daniel@...ll.ch
Cc:     linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM

On 06/05/2022 05:03, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
>    Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
>    Selected by [y]:
>    - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
> 
> DRM_DP_AUX_BUS depends on OF, so DRM_MSM also should depends on it.

I think the proper fix would be to make DRM_DP_AUX_BUS depend on OF || 
COMPILE_TEST rather than just OF

> 
> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/gpu/drm/msm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 4e0cbd682725..1d710a20ffdd 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -3,6 +3,7 @@
>   config DRM_MSM
>   	tristate "MSM DRM"
>   	depends on DRM
> +	depends on OF
>   	depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
>   	depends on COMMON_CLK
>   	depends on IOMMU_SUPPORT


-- 
With best wishes
Dmitry