linux-kernel - Re: [PATCH 1/2] selftests/ftrace: Save kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220506104621.bbeba7d977cdb5d95c3e7d87@kernel.org>
Date:   Fri, 6 May 2022 10:46:21 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Shuah Khan <shuah@...nel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] selftests/ftrace: Save kprobe_events to test log

On Thu,  5 May 2022 20:19:07 +0800
Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:

> It may lead to kernel panic when execute the following testcase on mips:
> 
>   # ./ftracetest test.d/kprobe/multiple_kprobes.tc
> 
> A preliminary analysis shows that the issue is related with
> 
>   echo 1 > events/kprobes/enable
> 
> after add the 256 probe points.
> 
> In order to find the root cause, I want to verify which probe point has
> problem, so it is necessary to save kprobe_events to test log.
> 
> With this patch, we can get the 256 probe points in the test log through
> the following command:
> 
>   # ./ftracetest test.d/kprobe/multiple_kprobes.tc -vvv -k

This looks good to me. :)

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you,

> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> index 312d237..be754f5 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> @@ -25,6 +25,8 @@ if [ $L -ne 256 ]; then
>    exit_fail
>  fi
>  
> +cat kprobe_events >> $testlog
> +
>  echo 1 > events/kprobes/enable
>  echo 0 > events/kprobes/enable
>  echo > kprobe_events
> -- 
> 2.1.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>