linux-kernel - Re: [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80715dbbf1f34853697e3aa6b3c74bc381000cc4.camel@HansenPartnership.com>
Date:   Fri, 06 May 2022 10:48:04 -0400
From:   James Bottomley <James.Bottomley@...senPartnership.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Changbin Du <changbin.du@...el.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        rust-for-linux <rust-for-linux@...r.kernel.org>,
        Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size

On Fri, 2022-05-06 at 14:58 +0200, Miguel Ojeda wrote:
> Hi James,
> 
> On Fri, May 6, 2022 at 1:19 PM James Bottomley
> <James.Bottomley@...senpartnership.com> wrote:
> > When you raise KSYM_NAME_LEN to 512, this on stack allocation
> > becomes 2049 bytes.  How did you manage not to trigger the frame
> > size warning, which is 1024 on 32 bit and 2048 on 64 bit by
> > default?
> 
> Thanks for taking a look!
> 
> If you mean `CONFIG_FRAME_WARN`, that applies to kernel objects, not
> scripts.

Oh, right, I missed that it was a script.  Forget the comment then; we
only have a restricted stack inside the kernel not in userspace.

James