linux-kernel - Re: (subset) [PATCH] soc: qcom: pdr: use static for servreg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165184936433.73465.7411487617454793164.b4-ty@linaro.org>
Date:   Fri,  6 May 2022 10:03:09 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     agross@...nel.org, Tom Rix <trix@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: (subset) [PATCH] soc: qcom: pdr: use static for servreg_* variables

On Fri, 22 Apr 2022 13:38:06 -0400, Tom Rix wrote:
> Sparse reports this repesentative issue
> pdr_internal.h:31:22: warning: symbol 'servreg_location_entry_ei' was not declared. Should it be static?
> Similar for other servreg_*
> 
> Global variables should not be defined in header files.
> This only works because pdr_internal.h is only included
> by pdr_interface.c.  Single file use variables should be
> static so add static to their storage-class specifiers.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: pdr: use static for servreg_* variables
      commit: 28e3dc8f8cd37eedc14e97e80a7a2e33359491df

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@...aro.org>