[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <165184936433.73465.16527836487625041409.b4-ty@linaro.org>
Date: Fri, 6 May 2022 10:03:06 -0500
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: Sankeerth Billakanti <quic_sbillaka@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
linux-kernel@...r.kernel.org, quic_kalyant@...cinc.com,
Kuogee Hsieh <quic_khsieh@...cinc.com>,
Rob Clark <robdclark@...omium.org>, devicetree@...r.kernel.org,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Matthias Kaehlcke <mka@...omium.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Andy Gross <agross@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, Stephen Boyd <swboyd@...omium.org>
Subject: Re: (subset) [PATCH v2] arm64: dts: qcom: sc7280: eDP for herobrine boards
On Tue, 26 Apr 2022 12:41:03 -0700, Douglas Anderson wrote:
> Add eDP support to herobrine boards, splitting up amongst the
> different files as makes sense. Rationale for the current split of
> things:
> * The eDP connector itself is on qcard. However, not all devices with
> a qcard will use an eDP panel. Some might use MIPI and, presumably,
> someone could build a device with qcard that had no display at all.
> * The qcard provides a PWM for backlight that goes to the eDP
> connector. This PWM is also provided to the board and it's expected
> that it would be used as the backlight PWM even for herobrine
> devices with MIPI displays.
> * It's currently assumed that all herobrine boards will have some sort
> of display, either MIPI or eDP (but not both).
> * We will assume herobrine-rev1 has eDP. The schematics allow for a
> MIPI panel to be hooked up but, aside from some testing, nobody is
> doing this and most boards don't have all the parts stuffed for
> it. The two panels would also share a PWM for backlight, which is
> weird.
> * herobrine-villager and herobrine-hoglin (crd) also have eDP.
> * herobrine-hoglin (crd) has slightly different regulator setup for
> the backlight. It's expected that this is unique to this board. See
> comments in the dts file.
> * There are some regulators that are defined in the qcard schematic
> but provided by the board like "vreg_edp_bl" and
> "vreg_edp_3p3". While we could put references to these regulators
> straight in the qcard.dtsi file, this would force someone using
> qcard that didn't provide those regulators to provide a dummy or do
> an ugly /delete-node/. Instead, we'll add references in
> herobrine.dtsi.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sc7280: eDP for herobrine boards
commit: 366a0a194b3b3e3e52bc7b7b1ac35b40a1187902
Best regards,
--
Bjorn Andersson <bjorn.andersson@...aro.org>
Powered by blists - more mailing lists