linux-kernel - Re: [PATCH v2 00/16] Introduce support for MediaTek MT8192 Google Chromebooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 May 2022 17:32:43 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Chen-Yu Tsai <wenst@...omium.org>,
        Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>, kernel@...labora.com,
        Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
        Fabien Parent <fparent@...libre.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Luca Weiss <luca@...tu.xyz>, Maxim Kutnij <gtk3@...ox.ru>,
        Rob Herring <robh+dt@...nel.org>,
        Sam Shih <sam.shih@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 00/16] Introduce support for MediaTek MT8192 Google
 Chromebooks

Il 06/05/22 13:41, Chen-Yu Tsai ha scritto:
> On Fri, May 6, 2022 at 3:46 AM Nícolas F. R. A. Prado
> <nfraprado@...labora.com> wrote:
>>
>>
>> This series introduces Devicetrees for the MT8192-based Asurada platform
>> as well as Asurada Spherion and Asurada Hayato boards.
>>
>> Support for the boards is added to the extent that is currently enabled
>> in the mt8192.dtsi, as to not add any dependencies to this series.
>>
>> Besides the other dt-binding fixes already on linux-next to avoid new
>> warnings by this series, [1] is already merged but not on next yet.
>>
>> This series was peer-reviewed internally before submission.
>>
>> [1] https://lore.kernel.org/all/20220429201325.2205799-1-nfraprado@collabora.com/
>>
>> v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@collabora.com/
>>
>> Changes in v2:
>> - Added patches 1-2 for Mediatek board dt-bindings
>> - Added patches 13-16 enabling hardware for Asurada that has since been
>>    enabled on mt8192.dtsi
>>
>> Nícolas F. R. A. Prado (16):
>>    dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion
>>    dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato
>>    arm64: dts: mediatek: Introduce MT8192-based Asurada board family
>>    arm64: dts: mediatek: asurada: Document GPIO names
>>    arm64: dts: mediatek: asurada: Add system-wide power supplies
>>    arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses
>>    arm64: dts: mediatek: asurada: Add ChromeOS EC
>>    arm64: dts: mediatek: asurada: Add keyboard mapping for the top row
>>    arm64: dts: mediatek: asurada: Add Cr50 TPM
>>    arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad
>>    arm64: dts: mediatek: asurada: Add I2C touchscreen
>>    arm64: dts: mediatek: spherion: Add keyboard backlight
>>    arm64: dts: mediatek: asurada: Enable XHCI
>>    arm64: dts: mediatek: asurada: Enable PCIe and add WiFi
>>    arm64: dts: mediatek: asurada: Add MT6359 PMIC
>>    arm64: dts: mediatek: asurada: Add SPMI regulators
> 
> Tested-by: Chen-Yu Tsai <wenst@...omium.org>
> 
> I tested all the external peripherals, including touchpad, touchscreen,
> keyboard (which needs a fix), USB, WiFi on both models, and the keyboard
> backlight and (USB-based) Bluetooth on Spherion.
> 
> Could you also enable the SCP? Otherwise the vcodec generates big warnings
> when it probes.
> 
> And also would like to see MMC. :)
> 
> 
> Thanks
> ChenYu

Hello ChenYu,

we avoided enabling the SCP and the MMC because of some things that have to be
assessed and fixed on our side.
For the SCP, we have some issues about loading the firmware, we suspect that the
binary that is in linux-firmware needs different and/or larger carveouts;
For the MMC, we have some issues with the pin configuration regarding the pins
drive strength: this should be solved, but we want to make sure that more testing
gets done before we push that upstream.

We're trying to upstream the Asurada platform step by step as to see these
machines present on upstream as soon as possible, with functionality that is
well tested and clean, so that it would make no sense to modify them again in
the near future.

As this series gets picked (hopefully) by the maintainer, we will then make sure
to send one (or more, depending on various factors) followup series enabling more
and more functionality, until the platform integration reaches 100% completion.

At least, that's the plan :-)

Cheers,
Angelo