linux-kernel - Re: [PATCH] ssb: remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220506172956.25004612@barney>
Date:   Fri, 6 May 2022 17:29:56 +0200
From:   Michael Büsch <m@...s.ch>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] ssb: remove unreachable code

On Fri,  6 May 2022 15:58:14 +0800
Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:

> Clean up the following smatch warning:
> 
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/ssb/pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 148bcb99c212..493bebbba521 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
>  				err = 0;
>  				goto out_free;
>  			}
> -			pr_warn("WARNING: Invalid SPROM CRC (corrupt
> SPROM)\n"); }
>  	}
>  	err = sprom_extract(bus, sprom, buf, bus->sprom_size);



Acked-by: Michael Büsch <m@...s.ch>

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped