linux-kernel - RE: [PATCH 2/2] mailbox: imx: fix duplicated initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU0PR04MB9417AFDAFE3F06B3F9274E1888C49@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Sat, 7 May 2022 06:52:28 +0000
From:   Peng Fan <peng.fan@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Tushar Khandelwal <Tushar.Khandelwal@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: RE: [PATCH 2/2] mailbox: imx: fix duplicated initializer

> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer
> 
> rxdb field is being initialized twice:
> 
>   drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [-
> Werror=override-init]
>     889 |         .rxdb   = imx_mu_generic_rxdb,
> 
> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Peng Fan <peng.fan@....com>

> ---
>  drivers/mailbox/imx-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index e88f544a1548..df8a785be324 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp =
> {
>  	.rx	= imx_mu_generic_rx,
>  	.rxdb	= imx_mu_generic_rxdb,
>  	.init	= imx_mu_init_generic,
> -	.rxdb	= imx_mu_generic_rxdb,
>  	.type	= IMX_MU_V2,
>  	.xTR	= 0x200,
>  	.xRR	= 0x280,
> --
> 2.32.0