linux-kernel - Re: [PATCH 0/2] iio: adc: stm32: Fix ADC IRQ handling on STM32F4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220507145845.06504c3b@jic23-huawei>
Date:   Sat, 7 May 2022 14:58:45 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Yannick Brosseau <yannick.brosseau@...il.com>, lars@...afoo.de,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        fabrice.gasnier@...s.st.com, olivier.moysan@...s.st.com,
        linux-iio@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] iio: adc: stm32: Fix ADC IRQ handling on STM32F4

On Sat, 07 May 2022 00:05:00 +0100
Paul Cercueil <paul@...pouillou.net> wrote:

> Hi Yannick,
> 
> Le ven., mai 6 2022 at 18:56:15 -0400, Yannick Brosseau 
> <yannick.brosseau@...il.com> a écrit :
> > Recent changes to the STM32 ADC irq handling broke the STM32F4 
> > platforms
> > These two patches bring it back to a working state.  
> 
> If the STM32 ADC was broken recently, and these two patches fix it, 
> then I'd expect to see a Fixes: tag on both commits and Cc: 
> linux-stable.

I normally add the Cc: for stable, but don't mind for obvious cases
if patches come in with it already there.

Sometimes the marking can be timing dependent (no point in sending
things to stable if they are going to hit in the same cycle etc)

Absolutely agree on fixes tag though!

Thanks,

Jonathan

> 
> Cheers,
> -Paul
> 
> > Yannick Brosseau (2):
> >   iio: adc: stm32: Iterate through all ADCs in irq handler
> >   iio: adc: stm32: Fix check for spurious IRQs on STM32F4
> > 
> >  drivers/iio/adc/stm32-adc-core.c | 7 ++++++-
> >  drivers/iio/adc/stm32-adc.c      | 9 ++++++---
> >  2 files changed, 12 insertions(+), 4 deletions(-)
> > 
> > --
> > 2.36.0
> >   
> 
>