linux-kernel - [norov:bitmap-cocci 15/15] kernel/sched/topology.c:2002:14: error: too many arguments to function 'cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 7 May 2022 21:51:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [norov:bitmap-cocci 15/15] kernel/sched/topology.c:2002:14: error:
 too many arguments to function 'cpumask_weight'

tree:   https://github.com/norov/linux bitmap-cocci
head:   3175a64928a804328d3f9a87af8bfda683539bee
commit: 3175a64928a804328d3f9a87af8bfda683539bee [15/15] sched/topology: replace cpumask_weight() with cpumask_weight_eq where appropriate
config: x86_64-randconfig-a004 (https://download.01.org/0day-ci/archive/20220507/202205072103.8QX1JxvR-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/norov/linux/commit/3175a64928a804328d3f9a87af8bfda683539bee
        git remote add norov https://github.com/norov/linux
        git fetch --no-tags norov bitmap-cocci
        git checkout 3175a64928a804328d3f9a87af8bfda683539bee
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_utility.c:89:
   kernel/sched/topology.c: In function 'sched_update_numa':
>> kernel/sched/topology.c:2002:14: error: too many arguments to function 'cpumask_weight'
    2002 |         if (!cpumask_weight(cpumask_of_node(node), 1))
         |              ^~~~~~~~~~~~~~
   In file included from include/linux/smp.h:13,
                    from include/linux/sched/clock.h:5,
                    from kernel/sched/build_utility.c:12:
   include/linux/cpumask.h:573:28: note: declared here
     573 | static inline unsigned int cpumask_weight(const struct cpumask *srcp)
         |                            ^~~~~~~~~~~~~~


vim +/cpumask_weight +2002 kernel/sched/topology.c

  1989	
  1990	/*
  1991	 * Call with hotplug lock held
  1992	 */
  1993	void sched_update_numa(int cpu, bool online)
  1994	{
  1995		int node;
  1996	
  1997		node = cpu_to_node(cpu);
  1998		/*
  1999		 * Scheduler NUMA topology is updated when the first CPU of a
  2000		 * node is onlined or the last CPU of a node is offlined.
  2001		 */
> 2002		if (!cpumask_weight(cpumask_of_node(node), 1))
  2003			return;
  2004	
  2005		sched_reset_numa();
  2006		sched_init_numa(online ? NUMA_NO_NODE : node);
  2007	}
  2008	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp