linux-kernel - Re: [PATCH v1 1/1] iio: proximity: srf04: Make use of device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 May 2022 15:33:06 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andreas Klinger <ak@...klinger.de>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/1] iio: proximity: srf04: Make use of device
 properties

On Wed,  4 May 2022 14:35:57 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/proximity/srf04.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
> index 4e6286765f01..05015351a34a 100644
> --- a/drivers/iio/proximity/srf04.c
> +++ b/drivers/iio/proximity/srf04.c
> @@ -37,9 +37,8 @@
>  #include <linux/err.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
>  #include <linux/sched.h>
> @@ -261,7 +260,7 @@ static int srf04_probe(struct platform_device *pdev)
>  
>  	data = iio_priv(indio_dev);
>  	data->dev = dev;
> -	data->cfg = of_match_device(of_srf04_match, dev)->data;
> +	data->cfg = device_get_match_data(dev);
>  
>  	mutex_init(&data->lock);
>  	init_completion(&data->rising);
> @@ -289,10 +288,8 @@ static int srf04_probe(struct platform_device *pdev)
>  		return PTR_ERR(data->gpiod_power);
>  	}
>  	if (data->gpiod_power) {
> -
> -		if (of_property_read_u32(dev->of_node, "startup-time-ms",
> -						&data->startup_time_ms))
> -			data->startup_time_ms = 100;
> +		data->startup_time_ms = 100;
> +		device_property_read_u32(dev, "startup-time-ms", &data->startup_time_ms);
>  		dev_dbg(dev, "using power gpio: startup-time-ms=%d\n",
>  							data->startup_time_ms);
>  	}