[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2ab35af2-b067-4243-35ed-a592a7046374@linaro.org>
Date: Sat, 7 May 2022 17:32:58 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Joel Selvaraj <jo@...amily.in>,
Thierry Reding <thierry.reding@...il.com>,
Sam Ravnborg <sam@...nborg.org>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Stanislav Jakubek <stano.jakubek@...il.com>,
Corentin Labbe <clabbe@...libre.com>,
Oleksij Rempel <linux@...pel-privat.de>,
Linus Walleij <linus.walleij@...aro.org>,
Hao Fang <fanghao11@...wei.com>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: display: Add bindings for EBBG FT8719
On 06/05/2022 14:17, Joel Selvaraj wrote:
> Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel,
> which can be found on some Xiaomi Poco F1 phones. The backlight is
> managed through the QCOM WLED driver.
>
> Signed-off-by: Joel Selvaraj <jo@...amily.in>
> ---
> .../bindings/display/panel/ebbg,ft8719.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
> new file mode 100644
> index 000000000000..fac6c9692c55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/ebbg,ft8719.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: EBBG FT8719 MIPI-DSI LCD panel
> +
> +maintainers:
> + - Joel Selvaraj <jo@...amily.in>
> +
> +description: |
> + The FT8719 panel from EBBG is a FHD+ LCD display panel with a resolution
> + of 1080x2246. It is a video mode DSI panel. The backlight is managed
> + through the QCOM WLED driver.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: ebbg,ft8719
> +
> + reg:
> + description: DSI virtual channel of the peripheral
maxItems
> +
> + reset-gpios:
> + description: phandle of gpio for reset line
Skip description - it's obvious.
> +
> + vddio-supply:
> + description: phandle of the Power IC supply regulator
s/phandle of//
> +
> + vddpos-supply:
> + description: phandle of the positive boost supply regulator
> +
> + vddneg-supply:
> + description: phandle of the negative boost supply regulator
> +
> + backlight: true
> + port: true
Both should not be needed - they come from panel-common.yaml. They might
stay in list
> +
> +required:
> + - compatible
> + - reg
> + - vddio-supply
> + - vddpos-supply
> + - vddneg-supply
> + - reset-gpios
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |+
No need for +
> + #include <dt-bindings/gpio/gpio.h>
> + dsi0 {
Just dsi
Best regards,
Krzysztof
Powered by blists - more mailing lists