linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c13621d1-8c33-2979-b455-2e1f4e4bc5c8@somainline.org>
Date:   Sat, 7 May 2022 19:35:53 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>,
        phone-devel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Markuss Broks <markuss.broks@...il.com>
Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Make regulator voltages
 multiple of step-size



On 7.05.2022 17:36, Marijn Suijten wrote:
> These voltages are not a multiple of the given step-size 8000 (with base
> voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and
> l22 failing to validate and in turn not probing the rpm-pm8998-regulator
> driver:
> 
>     l18: unsupportable voltage constraints 2856000-2848000uV
>     qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22
> 
> Round the voltages down for the sake of erring on the safe side, leaving
> a comment in place to document this discrepancy wrt downstream sources.
> 
> Fixes: 390883af89d2 ("arm64: dts: qcom: msm8998: Introduce support for Sony Yoshino platform")
> Reported-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> ---
Also:
Reported-by: Markuss Broks <markuss.broks@...il.com>

Konrad


>  .../dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts    | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
> index 4a1f98a21031..c21333aa73c2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
> @@ -26,11 +26,13 @@ &lab {
>  };
>  
>  &vreg_l18a_2p85 {
> -	regulator-min-microvolt = <2850000>;
> -	regulator-max-microvolt = <2850000>;
> +	/* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */
> +	regulator-min-microvolt = <2848000>;
> +	regulator-max-microvolt = <2848000>;
>  };
>  
>  &vreg_l22a_2p85 {
> -	regulator-min-microvolt = <2700000>;
> -	regulator-max-microvolt = <2700000>;
> +	/* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */
> +	regulator-min-microvolt = <2696000>;
> +	regulator-max-microvolt = <2696000>;
>  };