linux-kernel - Re: [PATCH v2 3/4] tpm: Implement command and response retry in tpm_tis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnbPAa0LZA3aGiZA@iki.fi>
Date:   Sat, 7 May 2022 22:56:49 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Johannes Holland <johannes.holland@...ineon.com>
Cc:     linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org, peterhuewe@....de,
        jgg@...pe.ca, krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH v2 3/4] tpm: Implement command and response retry in
 tpm_tis_core

On Fri, May 06, 2022 at 07:00:15PM +0200, Johannes Holland wrote:
> Some errors during command transmission and response reception are
> recoverable. Implement the specified retry mechanisms.
> 
> Recoverable errors during response reception:
>  * invalid response size during header read
>  * left over data:
>    a communication error can lead to a FIFO read of 0xFFs and an
>    unexpected STS.dataAvail = 1, subsequently
>  * CRC mismatch
> 
> Recoverable errors during transmit:
>  * CRC mismatch
> 
> Signed-off-by: Johannes Holland <johannes.holland@...ineon.com>

You should split this multiple patch, each implementing one retry
mechanism (CRC's can for recv and transmit can be in a single path
tho):

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes

BR, Jarkko