linux-kernel - Re: [PATCH] Add documentation for Enum value 'NR_DAMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220507201507.46050-1-sj@kernel.org>
Date:   Sat,  7 May 2022 20:15:07 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Gautam Menghani <gautammenghani201@...il.com>
Cc:     sj@...nel.org, skhan@...uxfoundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add documentation for Enum value 'NR_DAMON_OPS' in

Hi Gautam,


On Sat, 7 May 2022 22:26:20 +0530 Gautam Menghani <gautammenghani201@...il.com> wrote:

> Fix the warning - "Enum value 'NR_DAMON_OPS' not described in 
> enum 'damon_ops_id'" generated by the command "make pdfdocs"
> 
> Signed-off-by: Gautam Menghani <gautammenghani201@...il.com>
> ---
> Changes in v2:
> - Fix checkpatch warning of 75 characters per line
> - Fix email mismatch in from and signed by field

Thank you for the fix, but please read below.

Could you please adjust the subject so that we can know for what subsystem this
change is made?  E.g., mm/damon: Add documentation for ...

> 
>  include/linux/damon.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index f23cbfa4248d..b972a7a3b6f0 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -262,6 +262,7 @@ struct damos {
>   *
>   * @DAMON_OPS_VADDR:	Monitoring operations for virtual address spaces
>   * @DAMON_OPS_PADDR:	Monitoring operations for the physical address space
> + * @NR_DAMON_OPS:	Number of monitoring operations for a particular implementation

My previous comment to this part seems not answered?  I'd suggest
's/for a particular implementation/implementations/'


Thanks,
SJ

>   */
>  enum damon_ops_id {
>  	DAMON_OPS_VADDR,
> -- 
> 2.25.1
>