linux-kernel - Re: [PATCH v8 0/6] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220507213003.3373206-1-john.ernberg@actia.se>
Date:   Sat, 7 May 2022 21:30:16 +0000
From:   John Ernberg <john.ernberg@...ia.se>
To:     "a.fatoum@...gutronix.de" <a.fatoum@...gutronix.de>
CC:     "andreas@...mhold.de" <andreas@...mhold.de>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "david@...ma-star.at" <david@...ma-star.at>,
        "dhowells@...hat.com" <dhowells@...hat.com>,
        "ebiggers@...nel.org" <ebiggers@...nel.org>,
        "franck.lenormand@....com" <franck.lenormand@....com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "horia.geanta@....com" <horia.geanta@....com>,
        "j.luebbe@...gutronix.de" <j.luebbe@...gutronix.de>,
        "jarkko@...nel.org" <jarkko@...nel.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "jmorris@...ei.org" <jmorris@...ei.org>,
        John Ernberg <john.ernberg@...ia.se>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "matthias.schiffer@...tq-group.com" 
        <matthias.schiffer@...tq-group.com>,
        "pankaj.gupta@....com" <pankaj.gupta@....com>,
        "richard@....at" <richard@....at>,
        "s.trumtrar@...gutronix.de" <s.trumtrar@...gutronix.de>,
        "serge@...lyn.com" <serge@...lyn.com>,
        "sumit.garg@...aro.org" <sumit.garg@...aro.org>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        "zohar@...ux.ibm.com" <zohar@...ux.ibm.com>
Subject: Re: [PATCH v8 0/6] KEYS: trusted: Introduce support for NXP
 CAAM-based trusted keys

Hi Ahmad,

> > 
> > dmesg snips:
> > [    1.296772] trusted_key: Job Ring Device allocation for transform failed
> > ...
> > [    1.799768] caam 31400000.crypto: device ID = 0x0a16040000000100 (Era 9)
> > [    1.807142] caam 31400000.crypto: job rings = 2, qi = 0
> > [    1.822667] caam algorithms registered in /proc/crypto
> > [    1.830541] caam 31400000.crypto: caam pkc algorithms registered in /proc/crypto
> > [    1.841807] caam 31400000.crypto: registering rng-caam
> > 
> > I didn't quite have the time to get a better trace than that.
> 
> I don't see a crypto@...00000 node upstream. Where can I see your device tree?

Apologies for forgetting to mention that, I took it from the NXP tree
while removing the SM and SECO bits [1].
I also had to rebase some of their patches onto 5.17 for the CAAM to
probe, as the SCU makes some register pages unavailable.

> Initcall ordering does the right thing, but if CAAM device probe is deferred beyond
> late_initcall, then it won't help.
> 
> This is a general limitation with trusted keys at the moment. Anything that's
> not there by the time of the late_initcall won't be tried again. You can work
> around it by having trusted keys as a module. We might be able to do something
> with fw_devlinks in the future and a look into your device tree would help here,
> but I think that should be separate from this patch series.

Thank for you the explanation, it makes sense, and I agree that such work
would be a different patch set.

> 
> Please let me know if the module build improves the situation for you.
> 

After I changed trusted keys to a module I got it working. Which is good
enough for me as QXP CAAM support is not upstream yet.

Feel free to add my tested by if you need to make another spin.
Tested-by: John Ernberg <john.ernberg@...ia.se> # iMX8QXP

I didn't test v9 as I would have to patch around the new patch due to
the SCU.

Best regards // John Ernberg

[1]: https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/imx8-ss-security.dtsi?h=lf-5.10.y