linux-kernel - Re: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YneZhStpXcIFppPs@smile.fi.intel.com>
Date:   Sun, 8 May 2022 13:20:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Puyou Lu <puyou.lu@...il.com>, Andy Shevchenko <andy@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Petr Mladek <pmladek@...e.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Chris Down <chris@...isdown.name>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib/string_helpers: fix not adding strarray to
 device's resource list.

On Sat, May 07, 2022 at 11:45:16AM -0700, Andrew Morton wrote:
> On Fri,  6 May 2022 15:36:22 +0800 Puyou Lu <puyou.lu@...il.com> wrote:
> 
> > Add allocated strarray to device's resource list. This is a must to
> > automatically release strarray when the device disappears.
> 
> So at present we have a memory leak?

Yes.

> Is this likely to be serious enough to justify backporting the fix into
> -stable kernels?

I think so, however there are only few drivers are using it, hence it's
serious, but rare.

-- 
With Best Regards,
Andy Shevchenko