linux-kernel - Re: [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k0aw74ba.wl-maz@kernel.org>
Date:   Sun, 08 May 2022 10:37:45 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <tglx@...utronix.de>
Subject: Re: [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part()

On Sat, 07 May 2022 04:35:06 +0100,
Yang Yingliang <yangyingliang@...wei.com> wrote:
> 
> If kcalloc() fails, refcount of 'parts_node' should be decreased.
> 
> Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/irqchip/irq-gic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index b252d5534547..27a35aec2e48 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -1865,7 +1865,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
>  
>  	gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);
>  	if (!gic_data.ppi_descs)
> -		return;
> +		goto out_put_node;
>  
>  	nr_parts = of_get_child_count(parts_node);
>  

If you are concerned about this, then why not also address the memory
leak that occur on the same path?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.