linux-kernel - Re: [PATCH] net: phy: micrel: Fix incorret variable type in micrel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ynk5rc4/MrmBwBNP@shell.armlinux.org.uk>
Date:   Mon, 9 May 2022 16:56:29 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: micrel: Fix incorret variable type in micrel

Hi,

Please correct the spelling error of "incorrect" in the subject line.
Thanks.


On Mon, May 09, 2022 at 09:49:51PM +0800, Wan Jiabing wrote:
> In lanphy_read_page_reg, calling __phy_read() might return a negative
> error code. Use 'int' to check the negative error code.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  drivers/net/phy/micrel.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index a06661c07ca8..c34a93403d1e 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1959,7 +1959,7 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,
>  
>  static int lanphy_read_page_reg(struct phy_device *phydev, int page, u32 addr)
>  {
> -	u32 data;
> +	int data;
>  
>  	phy_lock_mdio_bus(phydev);
>  	__phy_write(phydev, LAN_EXT_PAGE_ACCESS_CONTROL, page);
> @@ -2660,8 +2660,7 @@ static int lan8804_config_init(struct phy_device *phydev)
>  
>  static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev)
>  {
> -	u16 tsu_irq_status;
> -	int irq_status;
> +	int irq_status, tsu_irq_status;
>  
>  	irq_status = phy_read(phydev, LAN8814_INTS);
>  	if (irq_status > 0 && (irq_status & LAN8814_INT_LINK))
> -- 
> 2.36.0
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!