linux-kernel - Re: [PATCH V1 4/5] iio: accel: bmi088: Make it possible to config scales.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202205100100.6k4OJbjS-lkp@intel.com>
Date:   Tue, 10 May 2022 01:24:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>, jic23@...nel.org,
        lars@...afoo.de, mchehab+huawei@...nel.org, ardeleanalex@...il.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH V1 4/5] iio: accel: bmi088: Make it possible to config
 scales.

Hi LI,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on v5.18-rc6 next-20220509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/LI-Qingwu/iio-accel-bmi088-support-BMI085-BMI090L/20220509-215750
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-randconfig-r013-20220509 (https://download.01.org/0day-ci/archive/20220510/202205100100.6k4OJbjS-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/70883e96ff4d7433fa8974815aba932f8bb2e8e7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review LI-Qingwu/iio-accel-bmi088-support-BMI085-BMI090L/20220509-215750
        git checkout 70883e96ff4d7433fa8974815aba932f8bb2e8e7
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/iio/accel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/iio/accel/bmi088-accel-core.c: In function 'bmi088_accel_set_scale':
>> drivers/iio/accel/bmi088-accel-core.c:244:13: warning: unused variable 'reg' [-Wunused-variable]
     244 |         int reg;
         |             ^~~
>> drivers/iio/accel/bmi088-accel-core.c:243:13: warning: unused variable 'ret' [-Wunused-variable]
     243 |         int ret;
         |             ^~~


vim +/reg +244 drivers/iio/accel/bmi088-accel-core.c

   239	
   240	static int bmi088_accel_set_scale(struct bmi088_accel_data *data, int val, int val2)
   241	{
   242		unsigned int i;
 > 243		int ret;
 > 244		int reg;
   245	
   246		for (i = 0; i < 4; i++)
   247			if (val == data->chip_info->scale_table[i][0] &&
   248			    val2 == data->chip_info->scale_table[i][1])
   249				break;
   250	
   251		if (i >= 4)
   252			return -EINVAL;
   253	
   254		return regmap_write(data->regmap, BMI088_ACCEL_REG_ACC_RANGE, i);
   255	}
   256	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp