linux-kernel - Re: [PATCH v1 1/2] serial: 8250_dw: Use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vca60m+mkPDzh022B4pU2sng8-ZLoEK0POLQON3EWjBKg@mail.gmail.com>
Date:   Mon, 9 May 2022 19:59:33 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v1 1/2] serial: 8250_dw: Use devm_add_action_or_reset()

On Mon, May 9, 2022 at 7:49 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
> Le 09/05/2022 à 19:21, Andy Shevchenko a écrit :

...

> > +static void dw8250_clk_disable_unprepare(void *data)
> > +{
> > +     clk_disable_unprepare(data);
> > +}

> we already have several time this function in different drivers.
> Maybe, it would be nice to have something standart for it.
>
> A devm_clk_prepare_enable() or something devm-helpers.h ([1])

Seems you missed the full story. We tried to add that several times
[1] and CCF maintainers refused all the time. You may work with them
to convince them.

[1]: https://lore.kernel.org/linux-clk/20210304221247.488173-2-linux@rasmusvillemoes.dk/
(the latest one AFAIK)

-- 
With Best Regards,
Andy Shevchenko