linux-kernel - RE: [EXT] Re: [PATCHv3 06/10]crypto: add rocksoft 64b crc framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY3PR18MB4530A713E7FB3CCD51F71A74A8C69@BY3PR18MB4530.namprd18.prod.outlook.com>
Date:   Mon, 9 May 2022 21:29:40 +0000
From:   Xiaoming Zhou <xzhou@...vell.com>
To:     Eric Biggers <ebiggers@...nel.org>
CC:     "kbusch@...nel.org" <kbusch@...nel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>, "hch@....de" <hch@....de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "colyli@...e.de" <colyli@...e.de>
Subject: RE: [EXT] Re: [PATCHv3 06/10]crypto: add rocksoft 64b crc framework

Agree.  The "11199E50_6128D175h" of 64b CRC Check in the Spec also is the AE8B1486_0A799888h with bits reversed.

Regards,
Xiaoming

-----Original Message-----
From: Eric Biggers <ebiggers@...nel.org> 
Sent: Monday, May 9, 2022 1:37 PM
To: Xiaoming Zhou <xzhou@...vell.com>
Cc: kbusch@...nel.org; linux-nvme@...ts.infradead.org; linux-block@...r.kernel.org; linux-crypto@...r.kernel.org; x86@...nel.org; linux-kernel@...r.kernel.org; axboe@...nel.dk; hch@....de; martin.petersen@...cle.com; colyli@...e.de
Subject: [EXT] Re: [PATCHv3 06/10]crypto: add rocksoft 64b crc framework

External Email

----------------------------------------------------------------------
On Sun, May 08, 2022 at 12:01:21AM +0000, Xiaoming Zhou wrote:
> Hi Keith,
> For the polynomial you used in this path is 0x9A6C9329AC4BC9B5ULL,  
> why it is different than the 0xAD93D23594C93659ULL defined in NVMe 
> command set spec
> 5.2.1.3.4 ? Though the crc66 implemented in this patch can pass with 
> test cases defined in Figure 121: 64b CRC Test Cases for 4KiB Logical 
> Block with no Metadata.  Could you explain the discrepancy between the spec and the patch?
> 

0x9A6C9329AC4BC9B5 is 0xAD93D23594C93659 with its bits reversed.

0xAD93D23594C93659 maps the polynomial coefficients to bits in the natural way.
However, writing the polynomial in this way isn't useful for this CRC variant, as it is a bit-reversed CRC.

- Eric