linux-kernel - Re: [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 May 2022 05:57:39 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Eugen.Hristev@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic
 node

On 03.05.2022 16:31, Eugen Hristev wrote:
> interrupt-parent is not to be used as a boolean property.
> It is already present in the DT in the proper way it's supposed to be used:
> interrupt-parent = <&gic>;
> 
> This is also reported by dtbs_check:
> arch/arm/boot/dts/at91-sama7g5ek.dtb: interrupt-controller@...11000: interrupt-parent: True is not of type 'array'
> 	From schema: /.local/lib/python3.8/site-packages/dtschema/schemas/interrupts.yaml
> 
> Fixes: 7540629e2fc7 ("ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek")
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

> ---
>  arch/arm/boot/dts/sama7g5.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index cdaa9c825f69..f4f174314e4e 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -949,7 +949,6 @@ gic: interrupt-controller@...11000 {
>  			#interrupt-cells = <3>;
>  			#address-cells = <0>;
>  			interrupt-controller;
> -			interrupt-parent;
>  			reg = <0xe8c11000 0x1000>,
>  				<0xe8c12000 0x2000>;
>  		};