linux-kernel - Re: [PATCH] fs/ufs: Replace kmap() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11975023.O9o76ZdvQC@leap>
Date:   Mon, 09 May 2022 08:04:54 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Evgeniy Dushistov <dushistov@...l.ru>,
        Ira Weiny <ira.weiny@...el.com>, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH] fs/ufs: Replace kmap() with kmap_local_page()

On lunedì 9 maggio 2022 01:44:13 CEST kernel test robot wrote:
> Hi "Fabio,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v5.18-rc6 next-20220506]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Fabio-M-De-Francesco/fs-ufs-Replace-kmap-with-kmap_local_page/20220509-040920
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/
linux.git e3de3a1cda5fdc3ac42cb0d45321fb254500595f
> config: arm-randconfig-s032-20220508 (https://download.01.org/0day-ci/
archive/20220509/202205090729.mU23mv8h-lkp@...el.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/
sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # apt-get install sparse
>         # sparse version: v0.6.4-dirty
>         # https://github.com/intel-lab-lkp/linux/commit/
e73d9919e2725b216318d5d02b8a184876ab3b11
>         git remote add linux-review https://github.com/intel-lab-lkp/
linux
>         git fetch --no-tags linux-review Fabio-M-De-Francesco/fs-ufs-
Replace-kmap-with-kmap_local_page/20220509-040920
>         git checkout e73d9919e2725b216318d5d02b8a184876ab3b11
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross 
C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm 
SHELL=/bin/bash fs/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
>    fs/ufs/namei.c: note: in included file:
> >> fs/ufs/ufs.h:114:32: sparse: sparse: marked inline, but without a 
definition
> >> fs/ufs/ufs.h:114:32: sparse: sparse: marked inline, but without a 
definition
> >> fs/ufs/ufs.h:114:32: sparse: sparse: marked inline, but without a 
definition
> 
> vim +114 fs/ufs/ufs.h
> 
>     99	
>    100	/* dir.c */
>    101	extern const struct inode_operations ufs_dir_inode_operations;
>    102	extern int ufs_add_link (struct dentry *, struct inode *);
>    103	extern ino_t ufs_inode_by_name(struct inode *, const struct qstr 
*);
>    104	extern int ufs_make_empty(struct inode *, struct inode *);
>    105	extern struct ufs_dir_entry *ufs_find_entry(struct inode *, const 
struct qstr *,
>    106						    struct page 
**, void **);
>    107	extern int ufs_delete_entry(struct inode *, struct ufs_dir_entry 
*, struct page *,
>    108				    char *);
>    109	extern int ufs_empty_dir (struct inode *);
>    110	extern struct ufs_dir_entry *ufs_dotdot(struct inode *, struct 
page **, void **);
>    111	extern void ufs_set_link(struct inode *dir, struct ufs_dir_entry 
*de,
>    112				 struct page *page, void 
*page_addr,
>    113				 struct inode *inode, bool 
update_times);
>  > 114	extern inline void ufs_put_page(struct page *page, void 
*page_addr);
>    115	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp

This will be fixed in v2.

Thanks,

Fabio