linux-kernel - Re: [PATCH] writeback: Avoid skipping inode writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yni42sWLMFITtfmz@infradead.org>
Date:   Sun, 8 May 2022 23:46:50 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Jing Xia <jing.xia@...soc.com>
Cc:     viro@...iv.linux.org.uk, jack@...e.cz, jing.xia.mail@...il.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] writeback: Avoid skipping inode writeback

On Thu, May 05, 2022 at 09:47:31PM +0800, Jing Xia wrote:
>  	if (!(inode->i_state & I_DIRTY_ALL))
>  		inode_cgwb_move_to_attached(inode, wb);
> +	else if (!(inode->i_state & I_SYNC_QUEUED) && (inode->i_state & I_DIRTY))

Please turn this into

	else if ((inode->i_state & I_DIRTY) &&
	         !(inode->i_state & I_SYNC_QUEUED))

to keep it a little more readable.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>