linux-kernel - Re: [PATCH] mm: Functions may simplify the use of return values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220509071924.GF76023@worktop.programming.kicks-ass.net>
Date:   Mon, 9 May 2022 09:19:24 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Li kunyu <kunyu@...china.com>
Cc:     dave.hansen@...ux.intel.com, luto@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, x86@...nel.org, hpa@...or.com,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH] mm: Functions may simplify the use of return values

On Sat, May 07, 2022 at 11:06:30PM +0800, Li kunyu wrote:
> p4d_clear_huge may be optimized for void return type and function usage.
> vunmap_p4d_range function saves a few steps here.

This makes it different from all the other p??_clear_huge() functions,
which seems like an exceedingly bad idea.