linux-kernel - Re: [PATCH v2] pcmcia: add MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a14LLfOs1YFnGj=1Qt_-kLQzg9_P1XgPRLZAC7OeWpCpA@mail.gmail.com>
Date:   Mon, 9 May 2022 09:21:45 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Stephen Zhang <starzhangzsd@...il.com>
Cc:     Dominik Brodowski <linux@...inikbrodowski.net>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Daniel Mack <daniel@...que.org>, zhangshida@...inos.cn,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pcmcia: add MIPS_DB1XXX dependence

On Mon, May 9, 2022 at 4:02 AM Stephen Zhang <starzhangzsd@...il.com> wrote:
>
> From: Shida Zhang <zhangshida@...inos.cn>
>
> drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
> arch/mips/alchemy/devboards/bcsr.c, which causes a link
> error:
>
> drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'
>
>
> So add MIPS_DB1XXX dependence.
>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> ---

Looks good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>