linux-kernel - Re: Re: [PATCH] mm: fix align-error when get_addr in unmapped_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 May 2022 17:23:02 +0800
From:   "lipeifeng@...o.com" <lipeifeng@...o.com>
To:     akpm <akpm@...ux-foundation.org>
Cc:     michel <michel@...pinasse.org>, hughd <hughd@...gle.com>,
        linux-mm <linux-mm@...ck.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "Barry Song" <21cnbao@...il.com>,
        zhangshiming <zhangshiming@...o.com>,
        peifengl55 <peifengl55@...il.com>
Subject: Re: Re: [PATCH] mm: fix align-error when get_addr in unmapped_area_topdown

Hi Andrew：

Thank you for your response.

> > > They caused me some merge issues against mapletree, which I had
> > > resolved.  Mapletree is dropped at present so I set these patches aside
>> > until the next version of the mapletree patches are available.
>>
>> Do we have a definite time for the next available version of the mapletree patches?

> I merged v2 a couple of days ago.  It should be in mm-unstable then
> linux-next early next week.

Ok, is "v2 merged" the patch from me?
1. mm-modify-the-method-to-search-addr-in-unmapped_area_topdown.patch added to -mm tree
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-modify-the-method-to-search-addr-in-unmapped_area_topdown.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-modify-the-method-to-search-addr-in-unmapped_area_topdown.patch

2. mm-fix-align-error-when-get_addr-in-unmapped_area_topdown.patch added to -mm tree
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-fix-align-error-when-get_addr-in-unmapped_area_topdown.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-fix-align-error-when-get_addr-in-unmapped_area_topdown.patch

> > Excuse me, is it possible for our patch to be independent of mapletree and brought in separately?

> Well, the changelog was rather unclear on the real-world end-user
> visible effects of the defect.  When these prioritization decisions are
> to be made, it really helps to have a clear view of the impact to our
> users.

Well, we had found that some apps-crash(TIF_32BIT) due to "Out of memory",  which the single largest remaining
free-addr-space is 12Mbytes in some case, we found that the processes wound fail to alloc
a 12Mbytes(align 1M) in the old methods so that Out-of-Memory.
such as Wechat and others Android apps.

> >
> > > I've been holding your patches until Michel Lespinasse has had time to
> > > review them (and hopefully explain them to me ;)).  Please review
> > > earlier comments which Michel has provided and ensure that those
> > > comments have been fully addressed so we can hopefully move forward on
> > > this.
> >
> > We will reply soon if Mr.Lespinasse provideds any advices or question.
> > And I haven't received any reply from Mr.Lespinasse yet, pls let me know
> > if i missed the reply.
>
> There was a big conference last week.

I missed it and if there any problems about the patches which need me to answer,
pls let me know and i hope i can give a clear reply.

Thank you very much indeed.

lipeifeng@...o.com

From: Andrew Morton
Date: 2022-05-08 05:59
To: lipeifeng@...o.com
CC: michel; hughd; linux-mm; linux-kernel; Barry Song; zhangshiming; peifengl55
Subject: Re: [PATCH] mm: fix align-error when get_addr in unmapped_area_topdown
On Mon, 2 May 2022 11:33:18 +0800 "lipeifeng@...o.com" <lipeifeng@...o.com> wrote:

> Hi Andrew：
>
> Thanks for your quick response.
>
> > They caused me some merge issues against mapletree, which I had
> > resolved.  Mapletree is dropped at present so I set these patches aside
> > until the next version of the mapletree patches are available.
>
> Do we have a definite time for the next available version of the mapletree patches?

I merged v2 a couple of days ago.  It should be in mm-unstable then
linux-next early next week.

> Excuse me, is it possible for our patch to be independent of mapletree and brought in separately?

Well, the changelog was rather unclear on the real-world end-user
visible effects of the defect.  When these prioritization decisions are
to be made, it really helps to have a clear view of the impact to our
users.

>
> > I've been holding your patches until Michel Lespinasse has had time to
> > review them (and hopefully explain them to me ;)).  Please review
> > earlier comments which Michel has provided and ensure that those
> > comments have been fully addressed so we can hopefully move forward on
> > this.
>
> We will reply soon if Mr.Lespinasse provideds any advices or question.
> And I haven't received any reply from Mr.Lespinasse yet, pls let me know
> if i missed the reply.

There was a big conference last week.