linux-kernel - Re: [PATCH -next] perf/x86/amd: Remove unused variable 'hwc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17be552a-ff87-0c9e-d963-fa00705e7a91@huawei.com>
Date:   Mon, 9 May 2022 11:07:09 +0800
From:   zhengzucheng <zhengzucheng@...wei.com>
To:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <namhyung@...nel.org>, <tglx@...utronix.de>,
        <bp@...en8.de>, <dave.hansen@...ux.intel.com>, <hpa@...or.com>
CC:     <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] perf/x86/amd: Remove unused variable 'hwc'

ping...

Any suggestions for this problem？

在 2022/4/21 19:10, Zucheng Zheng 写道:
> 'hwc' is never used in amd_pmu_enable_all(), so remove it.
>
> -------------------------------
>
> Signed-off-by: Zucheng Zheng <zhengzucheng@...wei.com>
> ---
>   arch/x86/events/amd/core.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
> index 8e1e818f8195..d7f9500b876d 100644
> --- a/arch/x86/events/amd/core.c
> +++ b/arch/x86/events/amd/core.c
> @@ -714,14 +714,11 @@ static void amd_pmu_enable_event(struct perf_event *event)
>   static void amd_pmu_enable_all(int added)
>   {
>   	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
> -	struct hw_perf_event *hwc;
>   	int idx;
>   
>   	amd_brs_enable_all();
>   
>   	for (idx = 0; idx < x86_pmu.num_counters; idx++) {
> -		hwc = &cpuc->events[idx]->hw;
> -
>   		/* only activate events which are marked as active */
>   		if (!test_bit(idx, cpuc->active_mask))
>   			continue;