linux-kernel - Re: [PATCH] writeback: Avoid skipping inode writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 May 2022 17:41:20 +0800
From:   jing xia <jing.xia.mail@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jing Xia <jing.xia@...soc.com>, viro@...iv.linux.org.uk,
        Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] writeback: Avoid skipping inode writeback

On Mon, May 9, 2022 at 2:46 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Thu, May 05, 2022 at 09:47:31PM +0800, Jing Xia wrote:
> >       if (!(inode->i_state & I_DIRTY_ALL))
> >               inode_cgwb_move_to_attached(inode, wb);
> > +     else if (!(inode->i_state & I_SYNC_QUEUED) && (inode->i_state & I_DIRTY))
>
> Please turn this into
>
>         else if ((inode->i_state & I_DIRTY) &&
>                  !(inode->i_state & I_SYNC_QUEUED))
>
> to keep it a little more readable.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@....de>

Ok. And thanks for the review.