linux-kernel - Re: [PATCH 1/2] entry: Rename arch_check_user_regs() to arch_enter_from_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnjlF8tTWt0yA5xm@osiris>
Date:   Mon, 9 May 2022 11:55:35 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Sven Schnelle <svens@...ux.ibm.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH 1/2] entry: Rename arch_check_user_regs() to
 arch_enter_from_user_mode()

On Mon, May 09, 2022 at 09:08:31AM +0200, Peter Zijlstra wrote:
> On Mon, May 09, 2022 at 08:20:41AM +0200, Sven Schnelle wrote:
> > Peter Zijlstra <peterz@...radead.org> writes:
> > 
> > > On Wed, May 04, 2022 at 08:23:50AM +0200, Thomas Richter wrote:
> > >> From: Sven Schnelle <svens@...ux.ibm.com>
> > >> 
> > >> arch_check_user_regs() is used at the moment to verify that struct pt_regs
> > >> contains valid values when entering the kernel from userspace. s390 needs
> > >> a place in the generic entry code to modify a cpu data structure when
> > >> switching from userspace to kernel mode. As arch_check_user_regs() is
> > >> exactly this, rename it to arch_enter_from_user_mode().
> > >> 
> > >> Cc: Thomas Gleixner <tglx@...utronix.de>
> > >> Cc: Peter Zijlstra <peterz@...radead.org>
> > >> Cc: Andy Lutomirski <luto@...nel.org>
> > >> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> > >> ---
> > >
> > > With the note that NMI doesn't (necessarily) call this..
> > >
> > > Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > 
> > How about:
> > 
> > "When entering the kernel from userspace, arch_check_user_regs() is
> >  used to verify that struct pt_regs contains valid values. Note that
> >  the NMI codepath doesn't call this function. s390 needs a place in the
> >  generic entry code to modify a cpu data structure when switching from
> >  userspace to kernel mode. As arch_check_user_regs() is exactly this,
> >  rename it to arch_enter_from_user_mode()."
> 
> Sure, thanks!

Merged into commit message, and applied both patches to s390 tree.

Thanks!