linux-kernel - Re: [PATCH v4 0/2] sched/core: Avoid obvious double update_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20b9822d-4a87-c868-1683-30b0a7e97777@bytedance.com>
Date:   Mon, 9 May 2022 11:16:39 +0800
From:   Hao Jia <jiahao.os@...edance.com>
To:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] sched/core: Avoid obvious double update_rq_clock
 warning

Friendly ping...

Hi Dietmar Eggemann & Peter Zijlstra,
If you have time, please review these two patches.

On 2022/4/30 Hao Jia wrote:
> These two patches are about the kernel scheduler:
> 
> patch 1: fixed the issue that kernel may trigger WARN_DOUBLE_CLOCK warning.
> patch 2: removed some no longer needed comments in the deadline scheduler
> and cleaned up the code.
> 
> Thanks for suggestion from Dietmar Eggemann & Peter Zijlstra.
> 
> v3->v4:
>     - Modify some code formats and commit messages.
>     - Add Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com> for
>       patch 1.
>     - Add Reviewed-by: Daniel Bristot de Oliveira <bristot@...hat.com>
>       for patch 2.
> 
> v2->v3:
>     - Modify some descriptions and errors in the commit information.
>     - Fixed a bug that might trigger the WARN_DOUBLE_CLOCK warning in
>       migrate_task_rq_dl().
>     - Add Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com> for
>       patch 2.
> 
> v1->v2:
>     - Added double_rq_clock_clear_update inline helper to clear RQCF_UPDATED
>       of rq->clock_update_flags.
>     - split into two separate patches.
> 
> [v1] https://lore.kernel.org/lkml/20220418090929.54005-1-jiahao.os@bytedance.com/
> [v2] https://lore.kernel.org/lkml/20220422090944.52618-1-jiahao.os@bytedance.com/
> [v3] https://lore.kernel.org/all/20220427080014.18483-1-jiahao.os@bytedance.com/
> 
> Hao Jia (2):
>    sched/core: Avoid obvious double update_rq_clock warning
>    sched/deadline: Remove superfluous rq clock update in push_dl_task()
> 
>   kernel/sched/core.c     |  6 +++---
>   kernel/sched/deadline.c | 13 ++++---------
>   kernel/sched/rt.c       |  5 +++--
>   kernel/sched/sched.h    | 28 ++++++++++++++++++++++++----
>   4 files changed, 34 insertions(+), 18 deletions(-)
>