linux-kernel - Re: [PATCH v3 10/11] null_blk: allow non power of 2 zoned devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aef68bcf-4924-8004-3320-325e05ca9b20@samsung.com>
Date:   Mon, 9 May 2022 13:06:18 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <jaegeuk@...nel.org>, <hare@...e.de>, <dsterba@...e.com>,
        <axboe@...nel.dk>, <hch@....de>, <snitzer@...nel.org>
CC:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        <bvanassche@....org>, <linux-fsdevel@...r.kernel.org>,
        <matias.bjorling@....com>, Jens Axboe <axboe@...com>,
        <gost.dev@...sung.com>, <jonathan.derrick@...ux.dev>,
        <jiangbo.365@...edance.com>, <linux-nvme@...ts.infradead.org>,
        <dm-devel@...hat.com>, Naohiro Aota <naohiro.aota@....com>,
        <linux-kernel@...r.kernel.org>,
        Johannes Thumshirn <jth@...nel.org>,
        Sagi Grimberg <sagi@...mberg.me>,
        Alasdair Kergon <agk@...hat.com>,
        <linux-block@...r.kernel.org>, Chaitanya Kulkarni <kch@...dia.com>,
        Keith Busch <kbusch@...nel.org>, <linux-btrfs@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH v3 10/11] null_blk: allow non power of 2 zoned devices


>> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
>> index 5cb4c92cd..ed9a58201 100644
>> --- a/drivers/block/null_blk/main.c
>> +++ b/drivers/block/null_blk/main.c
>> @@ -1929,9 +1929,8 @@ static int null_validate_conf(struct nullb_device *dev)
>>  	if (dev->queue_mode == NULL_Q_BIO)
>>  		dev->mbps = 0;
>>  
>> -	if (dev->zoned &&
>> -	    (!dev->zone_size || !is_power_of_2(dev->zone_size))) {
>> -		pr_err("zone_size must be power-of-two\n");
>> +	if (dev->zoned && !dev->zone_size) {
>> +		pr_err("zone_size must not be zero\n");
> 
> May be a simpler phrasing would be better:
> 
> pr_err("Invalid zero zone size\n");
> 
Ack. I will change this in the next rev.
>>  		return -EINVAL;
>>  	}
>>  
>> diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c
>> index dae54dd1a..00c34e65e 100644
>> --- a/drivers/block/null_blk/zoned.c
>> +++ b/drivers/block/null_blk/zoned.c
>> @@ -13,7 +13,10 @@ static inline sector_t mb_to_sects(unsigned long mb)
>>  
>>  static inline unsigned int null_zone_no(struct nullb_device *dev, sector_t sect)
>>  {
>> -	return sect >> ilog2(dev->zone_size_sects);
>> +	if (is_power_of_2(dev->zone_size_sects))
>> +		return sect >> ilog2(dev->zone_size_sects);
> 
> As a separate patch, I think we should really have ilog2(dev->zone_size_sects)
> as a dev field to avoid doing this ilog2 for every call..
> 
I don't think that is possible because `zone_size_sects` can also be non
po2.