linux-kernel - Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1d44fbb-c2a9-e422-8ce8-2a3982a75bb8@linaro.org>
Date:   Mon, 9 May 2022 13:46:25 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Andre Przywara <andre.przywara@....com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Russell King <linux@...linux.org.uk>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        Robin Murphy <robin.murphy@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple
 instances

On 06/05/2022 18:25, Andre Przywara wrote:
> When a machine sports more than one SP804 timer instance, we only bring
> up the first one, since multiple timers of the same kind are not useful
> to Linux. As this is intentional behaviour, we should not return an
> error message, as we do today:
> ===============
> [    0.000800] Failed to initialize '/bus@...0000/motherboard-bus@...0000/iofpga-bus@...000000/timer@...000': -22
> ===============
> 
> Replace the -EINVAL return with a debug message and return 0 instead.
> 
> Also we do not reach the init function anymore if the DT node is
> disabled (as this is now handled by OF_DECLARE), so remove the explicit
> check for that case.
> 
> This fixes a long standing bogus error when booting ARM's fastmodels.
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>
> ---

Applied, thanks


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog