linux-kernel - Re: [PATCH] staging: drivers: hid: hid-asus.c: Optimized input logic for keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e44ef1302b722d3bf7fafe55111e76f7173e6be.camel@perches.com>
Date:   Mon, 09 May 2022 06:54:51 -0700
From:   Joe Perches <joe@...ches.com>
To:     Johan Boger <jb@...fi>, jikos@...nel.org
Cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: drivers: hid: hid-asus.c: Optimized input
 logic for keys

On Mon, 2022-05-09 at 12:02 +0200, Johan Boger wrote:
> Instead of calling asus_map_key_clear() function in each case,
> we now set a temporary value and clear it after default.
> Patch was checked by checkpatch and adjusted accordingly.

This patch subject is not correct.  This is not a staging patch.

Your commit message is also incomplete as this is modifying comments,
changing whitespace, and changing brace styles.

and IMO:

Either use a single line case style like:

	case foo: statement; break;

or use a multiple line case style like:

	case foo:
		statement;
		break;

but please do not use a mixed case one line and statement; break;
on another like:

	case foo:
		statement; break;

Please remember checkpatch is only a guide, it's not the last word
on style where every message it emits requires an actual code change.

btw: there are _many_ single line case uses in the kernel

$ git grep  -P 'case\s+\w+\s*:\s*\w+' -- '*.[ch]' | wc -l
7581