[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YniS29/Mjabnbs2E@MiWiFi-R3L-srv>
Date: Mon, 9 May 2022 12:04:43 +0800
From: Baoquan He <bhe@...hat.com>
To: Catalin Marinas <catalin.marinas@....com>
Cc: Zhen Lei <thunder.leizhen@...wei.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
x86@...nel.org, "H . Peter Anvin" <hpa@...or.com>,
linux-kernel@...r.kernel.org, Dave Young <dyoung@...hat.com>,
Vivek Goyal <vgoyal@...hat.com>,
Eric Biederman <ebiederm@...ssion.com>,
kexec@...ts.infradead.org, Will Deacon <will@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
Rob Herring <robh+dt@...nel.org>,
Frank Rowand <frowand.list@...il.com>,
devicetree@...r.kernel.org, Jonathan Corbet <corbet@....net>,
linux-doc@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
Feng Zhou <zhoufeng.zf@...edance.com>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Chen Zhou <dingguo.cz@...group.com>,
John Donnelly <John.p.donnelly@...cle.com>,
Dave Kleikamp <dave.kleikamp@...cle.com>
Subject: Re: [PATCH v24 3/6] arm64: kdump: Reimplement crashkernel=X
On 05/07/22 at 07:50pm, Catalin Marinas wrote:
> On Sat, May 07, 2022 at 07:10:32AM +0800, Baoquan He wrote:
> > On 05/06/22 at 07:43pm, Zhen Lei wrote:
> > ......
> > > @@ -118,8 +162,7 @@ static void __init reserve_crashkernel(void)
> > > if (crash_base)
> > > crash_max = crash_base + crash_size;
> > >
> > > - /* Current arm64 boot protocol requires 2MB alignment */
> > > - crash_base = memblock_phys_alloc_range(crash_size, SZ_2M,
> > > + crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN,
> > > crash_base, crash_max);
> > > if (!crash_base) {
> > > pr_warn("cannot allocate crashkernel (size:0x%llx)\n",
> > > @@ -127,6 +170,11 @@ static void __init reserve_crashkernel(void)
> > > return;
> > > }
> > >
> >
> > There's corner case missed, e.g
> > 1) ,high and ,low are specified, CONFIG_ZONE_DMA|DMA32 is not enabled;
> > 2) ,high and ,low are specified, the whole system memory is under 4G.
>
> My view of ,low is that it should only used to override the default
> ZONE_DMA allocation if that one is not suitable. If no ZONE_DMA exists
> or everything is ZONE_DMA, ignore it altogether. That's a specialist
> case for people that know more about the memory layout, otherwise
> crashkernel=X works in most case with crashkernel=X,high as an
> alternative to allow high allocation.
Totally agree with the conclusion.
Powered by blists - more mailing lists