linux-kernel - Re: [PATCH] net: macb: Increment rx bd head after allocating skb and buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19e704ace63483a765a3298610218c5d110bb0e4.camel@redhat.com>
Date:   Tue, 10 May 2022 15:24:45 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Harini Katakam <harini.katakam@...inx.com>,
        nicolas.ferre@...rochip.com, davem@...emloft.net,
        claudiu.beznea@...rochip.com, kuba@...nel.org, dumazet@...gle.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        michal.simek@...inx.com, harinikatakamlinux@...il.com,
        radhey.shyam.pandey@...inx.com
Subject: Re: [PATCH] net: macb: Increment rx bd head after allocating skb
 and buffer

Hello,

On Mon, 2022-05-09 at 17:49 +0530, Harini Katakam wrote:
> In gem_rx_refill rx_prepared_head is incremented at the beginning of
> the while loop preparing the skb and data buffers. If the skb or data
> buffer allocation fails, this BD will be unusable BDs until the head
> loops back to the same BD (and obviously buffer allocation succeeds).
> In the unlikely event that there's a string of allocation failures,
> there will be an equal number of unusable BDs and an inconsistent RX
> BD chain. Hence increment the head at the end of the while loop to be
> clean.
> 
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>

This looks like targeting the "net" tree, please repost adding a
suitable Fixes tag.

Thanks,

Paolo