[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <514da5d6-9044-181f-bdd1-84b5b9abd346@roeck-us.net>
Date: Mon, 9 May 2022 20:36:19 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: cy_huang <u0084500@...il.com>, heikki.krogerus@...ux.intel.com,
gregkh@...uxfoundation.org, matthias.bgg@...il.com
Cc: cy_huang@...htek.com, bryan_huang@...htek.com,
linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tcpci_mt6360: Update for BMC PHY setting
On 5/9/22 18:44, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
>
> Update MT6360 BMC PHY Tx/Rx setting for the compatibility.
>
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
> Hi,
>
> Recently, there's some USBPD MT6360 IOP issue from the user.
>>>From our RD's comment, BMC PHY Tx/Rx setting need to be updated for
> the compatibility issue.
I think this needs to be a bit more detailed. What compatibility issue ?
Compatibility with what ?
Thanks,
Guenter
> ---
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index f1bd9e0..8a952ea 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -15,6 +15,9 @@
>
> #include "tcpci.h"
>
> +#define MT6360_REG_PHYCTRL1 0x80
> +#define MT6360_REG_PHYCTRL3 0x82
> +#define MT6360_REG_PHYCTRL7 0x86
> #define MT6360_REG_VCONNCTRL1 0x8C
> #define MT6360_REG_MODECTRL2 0x8F
> #define MT6360_REG_SWRESET 0xA0
> @@ -22,6 +25,8 @@
> #define MT6360_REG_DRPCTRL1 0xA2
> #define MT6360_REG_DRPCTRL2 0xA3
> #define MT6360_REG_I2CTORST 0xBF
> +#define MT6360_REG_PHYCTRL11 0xCA
> +#define MT6360_REG_RXCTRL1 0xCE
> #define MT6360_REG_RXCTRL2 0xCF
> #define MT6360_REG_CTDCTRL2 0xEC
>
> @@ -106,6 +111,27 @@ static int mt6360_tcpc_init(struct tcpci *tcpci, struct tcpci_data *tdata)
> if (ret)
> return ret;
>
> + /* BMC PHY */
> + ret = mt6360_tcpc_write16(regmap, MT6360_REG_PHYCTRL1, 0x3A70);
> + if (ret)
> + return ret;
> +
> + ret = regmap_write(regmap, MT6360_REG_PHYCTRL3, 0x82);
> + if (ret)
> + return ret;
> +
> + ret = regmap_write(regmap, MT6360_REG_PHYCTRL7, 0x36);
> + if (ret)
> + return ret;
> +
> + ret = mt6360_tcpc_write16(regmap, MT6360_REG_PHYCTRL11, 0x3C60);
> + if (ret)
> + return ret;
> +
> + ret = regmap_write(regmap, MT6360_REG_RXCTRL1, 0xE8);
> + if (ret)
> + return ret;
> +
> /* Set shipping mode off, AUTOIDLE on */
> return regmap_write(regmap, MT6360_REG_MODECTRL2, 0x7A);
> }
Powered by blists - more mailing lists