lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 May 2022 17:33:56 +0200 From: Antoine Tenart <atenart@...nel.org> To: Andrew Lunn <andrew@...n.ch> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>, Wan Jiabing <wanjiabing@...o.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2 net] net: phy: mscc: Add error check when __phy_read() failed Quoting Andrew Lunn (2022-05-10 17:08:07) > > But i doubt this impacts real users. MDIO tends to either work or not > work at all. And not working is pretty noticeable, and nobody has > reported issues. Right. On top of that there are other calls to __phy_read in this driver not checking the returned value. Plus all __phy_write calls. If that was found by code inspection I would suggest to improve the whole driver and not this function alone. Thanks, Antoine
Powered by blists - more mailing lists