linux-kernel - Re: [PATCH v3] ath10k: improve BDF search fallback strategy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875ymd8k68.fsf@kernel.org>
Date:   Tue, 10 May 2022 18:46:39 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Abhishek Kumar <kuabhs@...omium.org>
Cc:     netdev@...r.kernel.org, dianders@...omium.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        ath10k@...ts.infradead.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v3] ath10k: improve BDF search fallback strategy

Kalle Valo <kvalo@...nel.org> writes:

>>  static int ath10k_core_fetch_board_data_api_n(struct ath10k *ar,
>>  					      const char *boardname,
>> -					      const char *fallback_boardname1,
>> -					      const char *fallback_boardname2,
>>  					      const char *filename)
>>  {
>> -	size_t len, magic_len;
>> +	size_t len, magic_len, board_len;
>>  	const u8 *data;
>>  	int ret;
>> +	char temp_boardname[100];
>> +
>> +	board_len = 100 * sizeof(temp_boardname[0]);
>
> Why not:
>
> board_len = sizeof(temp_board-name);
>
> That way number 100 is used only once.

BTW I'm not sure if it makes sense to CC David, Eric, Jakub and Paolo.
I'm sure they get a lot of email already. And I would also drop netdev.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches