linux-kernel - Re: [PATCH] powerpc/eeh: Drop redundant spinlock initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08d9470c-20db-52b8-7015-84f0ed29ad0c@linux.ibm.com>
Date:   Tue, 10 May 2022 11:54:49 -0700
From:   Tyrel Datwyler <tyreld@...ux.ibm.com>
To:     Haowen Bai <baihaowen@...zu.com>,
        Russell Currey <ruscur@...sell.cc>,
        "Oliver O'Halloran" <oohall@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/eeh: Drop redundant spinlock initialization

On 5/10/22 02:53, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  arch/powerpc/platforms/pseries/eeh_pseries.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
> index f9af879c0222..77b476093e06 100644
> --- a/arch/powerpc/platforms/pseries/eeh_pseries.c
> +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
> @@ -848,7 +848,6 @@ static int __init eeh_pseries_init(void)
>  	}
> 
>  	/* Initialize error log lock and size */

Update the comment, or just drop it entirely?

-Tyrel

> -	spin_lock_init(&slot_errbuf_lock);
>  	eeh_error_buf_size = rtas_token("rtas-error-log-max");
>  	if (eeh_error_buf_size == RTAS_UNKNOWN_SERVICE) {
>  		pr_info("%s: unknown EEH error log size\n",