linux-kernel - Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220510012221-mutt-send-email-mst@kernel.org>
Date:   Tue, 10 May 2022 01:22:34 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     jasowang@...hat.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, virtualization@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()

On Mon, May 09, 2022 at 09:14:32PM +0800, Tang Bin wrote:
> In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
> in "default", so it canbe removed.
> 
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

What's the point of this?

> ---
>  drivers/net/virtio_net.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 87838cbe3..b3e5d8637 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
>  	case VIRTIO_NET_HASH_REPORT_IPv6_EX:
>  		rss_hash_type = PKT_HASH_TYPE_L3;
>  		break;
> -	case VIRTIO_NET_HASH_REPORT_NONE:
>  	default:
>  		rss_hash_type = PKT_HASH_TYPE_NONE;
>  	}
> -- 
> 2.20.1.windows.1
> 
>