linux-kernel - [PATCH] dt-bindings: Remove example file on dt-extract-example error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220510221333.2770571-1-robh@kernel.org>
Date:   Tue, 10 May 2022 17:13:32 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc:     Masahiro Yamada <masahiroy@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] dt-bindings: Remove example file on dt-extract-example error

As 'dt-extract-example' writes the example dts files to stdout, a file
is always created even on an error such as Ctrl-C. The resulting empty
file(s) then cause unexpected errors on subsequent builds. Fix this by
removing the output file on any error.

Signed-off-by: Rob Herring <robh@...nel.org>
---
 Documentation/devicetree/bindings/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index c9953f86b19d..c9fadff3dd74 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -20,7 +20,7 @@ check_dtschema_version:
 	{ echo "ERROR: dtschema minimum version is v$(DT_SCHEMA_MIN_VERSION)" >&2; false; }
 
 quiet_cmd_extract_ex = DTEX    $@
-      cmd_extract_ex = $(DT_EXTRACT_EX) $< > $@
+      cmd_extract_ex = $(DT_EXTRACT_EX) $< > $@ || rm $@
 
 $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
 	$(call if_changed,extract_ex)
-- 
2.34.1