linux-kernel - RE: [PATCH v7 3/8] watchdog: hpe-wdt: Introduce HPE GXP Watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR84MB171853A2C23FBD4BC9EA568D88C99@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Tue, 10 May 2022 23:56:42 +0000
From:   "Hawkins, Nick" <nick.hawkins@....com>
To:     Guenter Roeck <linux@...ck-us.net>,
        "Verdun, Jean-Marie" <verdun@....com>,
        "joel@....id.au" <joel@....id.au>, "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
Subject: RE: [PATCH v7 3/8] watchdog: hpe-wdt: Introduce HPE GXP Watchdog

On 5/6/22 12:13, nick.hawkins@....com wrote:
> From: Nick Hawkins <nick.hawkins@....com>
> 
> +	/* The register area where the timer and watchdog reside is disarranged.
> +	 * Hence mapping individual register blocks for the timer and watchdog
> +	 * is not recommended as they would have access to each others
> +	 * registers. Based on feedback the watchdog is no longer part of the
> +	 * device tree file and the timer driver now creates the watchdog as a
> +	 * child device. During the watchdogs creation, the timer driver passes
> +	 * the base address to the watchdog over the private interface.
> +	 */

/*
  * Please use standard multi-line comments in the watchdog subsystem.
  */

Hi Guenter,

Thank you for the feedback. I will fix this with a v8 version of the patchset.

-Nick