linux-kernel - Re: [PATCH] hwmon: (lm83) Remove unused include directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 May 2022 17:29:45 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Karl Mehltretter <kmehltretter@...il.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (lm83) Remove unused include directives

On Sun, May 08, 2022 at 04:46:01PM +0200, Karl Mehltretter wrote:
> Some include directives are no longer necessary due to previous driver
> changes. Remove them now to further improve driver code clarity.
> 
> Mutex usage has ceased since commit 719af4f1a40b ("hwmon: (lm83) Use
> regmap").
> 
> Ever since commit a0ac840d99fa ("hwmon: (lm83) Convert to use
> devm_hwmon_device_register_with_groups") functions sysfs_create_group
> and sysfs_remove_group are no longer used by the driver.
> 
> Signed-off-by: Karl Mehltretter <kmehltretter@...il.com>

Applied. Thanks!

Guenter

> ---
>  drivers/hwmon/lm83.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/lm83.c b/drivers/hwmon/lm83.c
> index 12370dcef..905f5689f 100644
> --- a/drivers/hwmon/lm83.c
> +++ b/drivers/hwmon/lm83.c
> @@ -24,10 +24,8 @@
>  #include <linux/init.h>
>  #include <linux/hwmon.h>
>  #include <linux/module.h>
> -#include <linux/mutex.h>
>  #include <linux/regmap.h>
>  #include <linux/slab.h>
> -#include <linux/sysfs.h>
>  
>  /*
>   * Addresses to scan